lkml.org 
[lkml]   [2013]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] new fscache interface to check cache consistency
From
David,

If the cache is withdrawn and we're starting anew I would consider
that to okay. I would consider an empty page cache for a cookie to be
consistent since there's nothing stale that I can read. Unless there's
another synchronization issue that I'm missing in fscache.

Thanks,
- Milosz

On Wed, Sep 4, 2013 at 12:24 PM, David Howells <dhowells@redhat.com> wrote:
> Hongyi Jia <jiayisuse@gmail.com> wrote:
>
>> +bool __fscache_check_consistency(struct fscache_cookie *cookie)
>> +{
>> + struct fscache_object *object;
>> +
>> + if (cookie->def->type != FSCACHE_COOKIE_TYPE_DATAFILE)
>> + return false;
>> +
>> + if (hlist_empty(&cookie->backing_objects))
>> + return false;
>> +
>> + object = hlist_entry(cookie->backing_objects.first,
>> + struct fscache_object, cookie_link);
>> +
>> + return object->cache->ops->check_consistency(object);
>> +}
>
> Hmmm... This isn't actually safe. You have to either:
>
> (1) hold cookie->lock whilst touching the object pointer when coming from the
> netfs side, or:
>
> (2) set up an operation to do this (as, say, __fscache_alloc_page() does).
>
> The problem is that you have nothing to defend against the object being
> withdrawn by the cache under you.
>
> David


\
 
 \ /
  Last update: 2013-09-04 19:21    [W:0.048 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site