Messages in this thread | | | Date | Wed, 4 Sep 2013 12:18:28 +0200 | From | Thierry Reding <> | Subject | Re: [GIT PULL] KVM changes for 3.12 |
| |
On Tue, Sep 03, 2013 at 03:10:46PM +0300, Gleb Natapov wrote: [...] > Aneesh Kumar K.V (5): > mm/cma: Move dma contiguous changes into a seperate config
Hi Gleb,
This commit is going to cause runtime regressions on various ARM platforms because it renames a symbol but fails to update all default configurations that select the symbol. A quick grep shows that three ARM platforms are affected:
$ git grep CONFIG_CMA=y arch/arm/configs/keystone_defconfig:CONFIG_CMA=y arch/arm/configs/omap2plus_defconfig:CONFIG_CMA=y arch/arm/configs/tegra_defconfig:CONFIG_CMA=y
I've been digging around a bit and it seems like the original patch from Aneesh had the defconfig changes but they were dropped because they "... require separate handling to avoid pointless merge conflicts."[0]
While I can't speak for Keystone or OMAP, at least on Tegra this causes issues because we use CMA for framebuffer allocation. Since we only have CMA selected but not the new DMA_CMA, large DMA allocations will fail.
Can we have the defconfig changes added back to this patch, please? I suspect that Linus can handle any resulting merge conflicts.
Thierry
[0]: http://permalink.gmane.org/gmane.linux.kernel.mm/102707 [unhandled content-type:application/pgp-signature] | |