Messages in this thread | | | From | Sonny Rao <> | Date | Mon, 30 Sep 2013 17:28:41 -0700 | Subject | Re: [PATCH] perf session: Fix infinite loop on invalid perf.data file |
| |
On Mon, Sep 30, 2013 at 6:49 AM, David Ahern <dsahern@gmail.com> wrote: > On 9/30/13 2:19 AM, Namhyung Kim wrote: >> >> From: Namhyung Kim <namhyung.kim@lge.com> >> >> perf-record updates the header in the perf.data file at termination. >> Without this update perf-report (and other processing built-ins) it >> caused an infinite loop when perf report (or something like) called. >> >> This is because the algorithm in __perf_session__process_events() >> depends on the data_size which is read from file header. Use file >> size directly instead in this case to do the best-effort processing. >> >> Cc: David Ahern <dsahern@gmail.com> >> Cc: Sonny Rao <sonnyrao@chromium.org> >> Signed-off-by: David Ahern <dsahern@gmail.com> >> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > > worked ok for me. Sonny can you verify?
Yes, it works for me as well, thanks!
> David >
| |