Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 2/3] perf stat: Don't require a workload when using system wide or CPU options | Date | Mon, 30 Sep 2013 17:47:34 +0900 |
| |
Hi David,
On Sat, 28 Sep 2013 14:27:59 -0600, David Ahern wrote: > perf-stat can do system wide counters or one or more cpus. For > these options do not require a workload to be specified. > > Signed-off-by: David Ahern <dsahern@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Namhyung Kim <namhyung.kim@lge.com> > Cc: Stephane Eranian <eranian@google.com> > --- > tools/perf/builtin-stat.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 6cc0aa2..60239fe 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1517,8 +1517,10 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused) > } else if (big_num_opt == 0) /* User passed --no-big-num */ > big_num = false; > > - if (!argc && !perf_target__has_task(&target)) > + if (!argc && !perf_target__has_task(&target) && > + !perf_target__has_cpu(&target))
You can use perf_target__none() for this.
Btw I found a bug in setting child_pid (which introduced by me ;) during this review. Will send a fix.
Thanks, Namhyung
> usage_with_options(stat_usage, options); > + > if (run_count < 0) { > usage_with_options(stat_usage, options); > } else if (run_count == 0) {
| |