Messages in this thread | | | Date | Mon, 30 Sep 2013 21:09:39 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf auto-dep: Speed up feature tests by building them in parallel |
| |
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Mon, Sep 30, 2013 at 02:27:41PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Sep 30, 2013 at 02:12:20PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Mon, Sep 30, 2013 at 06:42:10PM +0200, Ingo Molnar escreveu: > > > > This series (with combo patch attached) implements (much) faster > > > > perf-tools feature-auto-detection. > > > > Cool stuff! > > > > Testing: > > > Removed python-devel and it correctly turned those off: > > ... libpython: [ OFF ] > ... libpython-version: [ OFF ] > > One possible way to speed this up a bit more would be to somehow state > that if the test A fails, then don't even bother testing test B, like in > the case above.
Yeah, that's possible in a way, I did it in another case, see how the 'bionic' test for Android libc gets executed separately (but still unconditionally - we should probably only execute it if the libc test fails).
The 'FEATURE_TESTS' variable holds the 'flat' list of features that we want to definitely test.
Also, if glibc test passes then perhaps the strlcpy() test does not have to be executed at all.
In the initial version I wanted to maintain the existing feature dependency.
Thanks,
Ingo
| |