lkml.org 
[lkml]   [2013]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 086/104] HID: picolcd_core: validate output report details
    Date
    3.5.7.22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kees Cook <keescook@chromium.org>

    commit 1e87a2456b0227ca4ab881e19a11bb99d164e792 upstream.

    A HID device could send a malicious output report that would cause the
    picolcd HID driver to trigger a NULL dereference during attr file writing.

    [jkosina@suse.cz: changed

    report->maxfield < 1

    to

    report->maxfield != 1

    as suggested by Bruno].

    CVE-2013-2899

    Signed-off-by: Kees Cook <keescook@chromium.org>
    Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
    Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    [ luis: backported to 3.5:
    - file rename drivers/hid/hid-picolcd_core.c ->
    drivers/hid/hid-picolcd.c ]
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/hid/hid-picolcd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
    index 45c3433..95f9047 100644
    --- a/drivers/hid/hid-picolcd.c
    +++ b/drivers/hid/hid-picolcd.c
    @@ -1424,7 +1424,7 @@ static ssize_t picolcd_operation_mode_store(struct device *dev,
    buf += 10;
    cnt -= 10;
    }
    - if (!report)
    + if (!report || report->maxfield != 1)
    return -EINVAL;

    while (cnt > 0 && (buf[cnt-1] == '\n' || buf[cnt-1] == '\r'))
    --
    1.8.3.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-09-30 13:21    [W:4.199 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site