Messages in this thread | | | Date | Wed, 04 Sep 2013 09:00:36 +0800 | From | Tang Chen <> | Subject | Re: [PATCH 06/11] memblock: Improve memblock to support allocation from lower address. |
| |
On 09/04/2013 08:24 AM, Toshi Kani wrote: ...... >> +phys_addr_t __init_memblock >> +__memblock_find_range(phys_addr_t start, phys_addr_t end, >> + phys_addr_t size, phys_addr_t align, int nid) > > This func should be static as it must be an internal func. > ...... >> +phys_addr_t __init_memblock >> +__memblock_find_range_rev(phys_addr_t start, phys_addr_t end, >> + phys_addr_t size, phys_addr_t align, int nid) > > Ditto. ...... >> + if (memblock.current_order == MEMBLOCK_ORDER_DEFAULT) > > This needs to use MEMBLOCK_ORDER_HIGH_TO_LOW since the code should be > independent from the value of MEMBLOCK_ORDER_DEFAULT. >
OK, followed.
Thanks.
| |