lkml.org 
[lkml]   [2013]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC, 14/18, v2] ftrace/lockdep: Have the RCU lockdep splat show what function triggered
On Sun, 01 Sep 2013 16:28:36 +0800
Wang Shilong <wangshilong1991@gmail.com> wrote:

> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: printk() should include KERN_ facility level
> #90: FILE: kernel/trace/trace_functions.c:583:
> + printk("ftrace_rcu_func: %pS\n",
>
> total: 0 errors, 1 warnings, 53 lines checked
>
> patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>

The code is called by lockdep, which uses printk() directly as well.
This will stay a printk() until lockdep changes.

And please, do not send a patch to change lockdep.

-- Steve

> Thanks, Wang
>
> Notic: this is an automated generated by shell script
> Any problems please contact: wangshilong1991@gmail.com



\
 
 \ /
  Last update: 2013-09-04 03:21    [W:0.147 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site