Messages in this thread | | | Date | Tue, 3 Sep 2013 15:18:08 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions |
| |
On Tue, Sep 03, 2013 at 05:15:16PM -0400, Steven Rostedt wrote: > On Sat, 31 Aug 2013 01:11:18 -0400 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index a6d098c..3750360 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -1356,6 +1356,23 @@ ftrace_hash_rec_disable(struct ftrace_ops *ops, int filter_hash); > > static void > > ftrace_hash_rec_enable(struct ftrace_ops *ops, int filter_hash); > > > > +static int ftrace_convert_size_to_bits(int size) > > +{ > > + int bits; > > + > > + /* > > + * Make the hash size about 1/2 the # found > > + */ > > + for (size /= 2; size; size >>= 1) > > + bits++; > > + > > + /* Don't allocate too much */ > > + if (bits > FTRACE_HASH_MAX_BITS) > > + bits = FTRACE_HASH_MAX_BITS; > > + > > + return bits; > > +} > > + > > Just found this bug. Strange that gcc never gave me a warning :-/
I can't give gcc too much trouble, as I also didn't give you an uninitialized-variable warning.
Thanx, Paul
| |