Messages in this thread | | | Date | Tue, 3 Sep 2013 14:27:31 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface |
| |
Hello,
On Tue, Sep 03, 2013 at 06:19:06PM +0200, Alexander Gordeev wrote: > We must enable maximum possible number of MSIs - the one reported in > Multiple Message Capable register. Otherwise ICH device will fallback > to MRSM. IOW, if the result of roundup_pow_of_two(n_ports) is not what > in Multiple Message Capable register (i.e. as roundup_pow_of_two(6) vs 16) > ICH will enforce MRSM mode.
Hmmm... I think the interface in general is pretty messy. Wouldn't it be much cleaner to have a separate function to query MSICAP and let the function just return success / failure?
Thanks.
-- tejun
| |