lkml.org 
[lkml]   [2013]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface
On Mon, Sep 02, 2013 at 11:00:28AM +0200, Alexander Gordeev wrote:
> + if (hpriv->flags & AHCI_HFLAG_NO_MSI)
> + goto intx;
> +
> + rc = pci_enable_msi_block_part(pdev, n_ports, AHCI_MAX_PORTS);
> + if (!rc)
> + return AHCI_MAX_PORTS;
> + if (rc < 0)
> + goto intx;
> +
> + maxvec = rc;
> + rc = pci_enable_msi_block_part(pdev, n_ports, maxvec);
> + if (!rc)
> + return maxvec;
> + if (rc < 0)
> + goto intx;

Why is the above fallback necessary? The only other number which
makes sense is roundup_pow_of_two(n_ports), right? What does the
above fallback logic buy us?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-09-03 16:41    [W:0.598 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site