Messages in this thread | | | Date | Tue, 3 Sep 2013 14:10:51 +0200 | Subject | Re: [PATCH 1/2] gpio: Fix crash in gpiod_set_debounce() | From | Linus Walleij <> |
| |
On Tue, Sep 3, 2013 at 12:39 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> Return an error if neither the ->set() nor the ->set_debounce() function > is implemented by the chip. Furthermore move locking further down so the > lock doesn't have to be unlocked on error. This is safe to do because at > this point the lock doesn't protect anything. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > Linus, > > Feel free to squash this into the commit that introduced these: > > fc9bbfb: gpio: improve error path in gpiolib
Hm I fixed part of this bug yesterday, but screwed up and left the dangling spinlock in there, what is wrong with me :-(
Anyway, fixed it _finally_ now, thanks to you.
Yours, Linus Walleij
| |