Messages in this thread | | | Subject | Re: [BUG/RFC 3/3] perf tools: Add missing GTK2_SUPPORT ifdefs | From | Namhyung Kim <> | Date | Sun, 29 Sep 2013 15:54:25 +0900 |
| |
Hi Arnaldo,
2013-09-27 (금), 15:54 -0300, Arnaldo Carvalho de Melo: > Em Fri, Sep 27, 2013 at 04:32:12PM +0200, Jiri Olsa escreveu: > > When building minimal perf via: > > NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 > > NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 > > NO_LIBBIONIC=1 > > > > We dont link -ldl and that's causing error for gtk2 related code, > > which is disabled on command line (NO_GTK2), but not in the code > > (GTK2_SUPPORT). > > > > We probably need some global fix/change for this browser > > enabled/disable code. > > But for now what you did is enough, since the only module that uses > the dl mechanism is the GTK+ one, so I'm applying it. > > I should have detected this before pushing out perf/core with the > changes that introduced this problem, that is what: > > make -C tools/perf -f tests/make > > was made to catch, my bad, Namhyung, please use those tests next time > too :-)
I almost forgot about that, sorry. Will do the tests next time.
Thanks, Namhyung
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |