lkml.org 
[lkml]   [2013]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] i2c-ismt: add Initialize DMA buffer code ismt_access()
On Thu, Sep 26, 2013 at 10:41:15AM -0400, Neil Horman wrote:
> On Thu, Sep 26, 2013 at 10:40:32AM +0200, Wolfram Sang wrote:
> > On Tue, Sep 24, 2013 at 04:47:55PM -0700, James Ralston wrote:
> > > This patch adds code to Initialize the DMA buffer to compensate for possible hardware data corruption.
> >
> > Take care of the line width here.
> >
> > > Signed-off-by: James Ralston <james.d.ralston@intel.com>
> > > ---
> > > drivers/i2c/busses/i2c-ismt.c | 3 +++
> > > 1 files changed, 3 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> > > index 8ed79a0..d3f30ea 100644
> > > --- a/drivers/i2c/busses/i2c-ismt.c
> > > +++ b/drivers/i2c/busses/i2c-ismt.c
> > > @@ -393,6 +393,9 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr,
> > >
> > > desc = &priv->hw[priv->head];
> > >
> > > + /* Initialize the DMA buffer */
> > > + memset(priv->dma_buffer, 0, (I2C_SMBUS_BLOCK_MAX+1));
> >
> > sizeof()?
> >
> Agreed.

Fixed that myself so it can be in my pull-request to Linus today.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-09-28 15:41    [W:0.205 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site