Messages in this thread | | | Date | Sat, 28 Sep 2013 10:52:03 +0200 | From | Ingo Molnar <> | Subject | Re: [pchecks v1 4/4] percpu: Add preemption checks to __this_cpu ops |
| |
* Christoph Lameter <cl@linux.com> wrote:
> On Wed, 25 Sep 2013, Ingo Molnar wrote: > > > > And then instead of thanks I get insults sprinkled with some paranoia. > > > > Pointing out your lack of cooperation (such as repeatedly ignoring > > maintainer feedback) is not an "insult" - it's my duty as a maintainer > > to protect other submitters who do their homework and it's also my > > duty as a maintainer to keep crappy patches from entering the kernel. > > Resisting low-quality patches like yours and pointing out patch > > submission errors and inefficiencies is my job. > > Thats paranoia. [...]
Pointing out your track record is not paranoia nor an insult - it's merely embarrassing to you. And it's not just me: I heard similar complaints about you from other maintainers as well and I had to use a heavy NAK here to make you cooperate and listen already...
> [...] No lack of cooperation. Feedback to patches during development is > normal until they reach proper maturity for merging. Thats why these > things are usually versioned.
What I'm complaining about is you _ignoring_ feedback - such as when you ignored PeterZ's feedback.
This is kernel development 101: every new version of a series must address _all_ previously given feedback - or if does not do so it should very prominently explain why it has not done so.
If you "don't have time" to do it properly then you need to wait more between posting new versions of a series, to not make other people waste time reviewing the series and discovering that the review they gave against a prior series got ignored by you...
Thanks,
Ingo
| |