Messages in this thread | | | Date | Sat, 28 Sep 2013 00:16:20 +0530 | From | George Cherian <> | Subject | Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ |
| |
On 9/27/2013 1:05 PM, Javier Martinez Canillas wrote: > On 09/27/2013 01:18 AM, Stephen Warren wrote: >> On 09/24/2013 01:58 AM, Javier Martinez Canillas wrote: >>> The OMAP GPIO controller HW requires a pin to be configured in GPIO >>> input mode in order to operate as an interrupt input. Since drivers >>> should not be aware of whether an interrupt pin is also a GPIO or not, >>> the HW should be fully configured/enabled as an IRQ if a driver solely >>> uses IRQ APIs such as request_irq(), and never calls any GPIO-related >>> APIs. As such, add the missing HW setup to the OMAP GPIO controller's >>> irq_chip driver. >>> >>> Since this bypasses the GPIO subsystem we have to ensure that another >>> caller won't be able to request the same GPIO pin that is used as an >>> IRQ and set its direction as output. Requesting the GPIO and setting >>> its direction as input is allowed though. >> FWIW, the concept of this patch, >> Acked-by: Stephen Warren <swarren@nvidia.com> >> >> I didn't review the code; just skimmed it to see where the new >> functionality was implemented. >> > Thanks Stephen, > > I split the changes as suggested by Tony and posted as a patch-set and not an > RFC anymore: > > [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately [1] > [PATCH 2/2] gpio/omap: auto-setup a GPIO when used as an IRQ [2] > > Linus, > > Could you please add Stephen Acked-by when taking the patches and also George > Cherian Tested-by that sent for this RFC. George it would be great if you can > also comment on which OMAP platform you had tested.
Tested on dra7xx/evm with GPIO interrupt for pcf gpio expander. Tested-by: George Cherian <george.cherian@ti.com> > > I cc'ed Aaro Koskinen and Paul Walmsley now which seems to have OMAP1 platforms > to test. Could you please test [1] and [2] on a OMAP1 board? These patches > solves a long standing issue we have on OMAP2+ when booting with DT and it would > be great if you can check that it does not cause regressions on OMAP1 based boards. > > Thanks a lot and best regards, > Javier > > [1]: https://patchwork.kernel.org/patch/2937351/ > [2]: https://patchwork.kernel.org/patch/2937371/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- -George
| |