lkml.org 
[lkml]   [2013]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/63] sched: numa: Continue PTE scanning even if migrate rate limited
    Date
    From: Peter Zijlstra <peterz@infradead.org>

    Avoiding marking PTEs pte_numa because a particular NUMA node is migrate rate
    limited sees like a bad idea. Even if this node can't migrate anymore other
    nodes might and we want up-to-date information to do balance decisions.
    We already rate limit the actual migrations, this should leave enough
    bandwidth to allow the non-migrating scanning. I think its important we
    keep up-to-date information if we're going to do placement based on it.

    Signed-off-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Mel Gorman <mgorman@suse.de>
    ---
    kernel/sched/fair.c | 8 --------
    1 file changed, 8 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index db83eb1..f2580ce 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -951,14 +951,6 @@ void task_numa_work(struct callback_head *work)
    */
    p->node_stamp += 2 * TICK_NSEC;

    - /*
    - * Do not set pte_numa if the current running node is rate-limited.
    - * This loses statistics on the fault but if we are unwilling to
    - * migrate to this node, it is less likely we can do useful work
    - */
    - if (migrate_ratelimited(numa_node_id()))
    - return;
    -
    start = mm->numa_scan_offset;
    pages = sysctl_numa_balancing_scan_size;
    pages <<= 20 - PAGE_SHIFT; /* MB in pages */
    --
    1.8.1.4


    \
     
     \ /
      Last update: 2013-09-27 17:41    [W:4.136 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site