[lkml]   [2013]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] checkpatch: Make the memory barrier test noisier
On Fri, Sep 27, 2013 at 07:14:17AM -0700, Joe Perches wrote:
> Peter Zijlstra prefers that comments be required near uses
> of memory barriers.
> Change the message level for memory barrier uses from a
> --strict test only to a normal WARN so it's always emitted.
> This might produce false positives around insertions of
> memory barriers when a comment is outside the patch context
> block.

One would argue that in that case they're too far away in any case :-)

> And checkpatch is still stupid, it only looks for existence
> of any comment, not at the comment content.

Could we try and alleviate this by giving a slightly more verbose

Maybe something like:

memory barrier without comment; please refer to the pairing barrier and
describe the ordering requirements.

> Suggested-by: Peter Zijlstra <>
> Signed-off-by: Joe Perches <>

Acked-by: Peter Zijlstra <>

 \ /
  Last update: 2013-09-27 17:21    [W:0.115 / U:2.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site