lkml.org 
[lkml]   [2013]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT
From
On Thu, Sep 26, 2013 at 2:48 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> Recent movement of all configurations of pin in the single call of
> pin_config_set(), it is aborting configuration if BIAS_PULL_PIN_DEFAULT
> is selected as return of configuration.
>
> The original idea was to just avoid any update on register for pull up/down
> configuration if this option is selected.
>
> Fixing this by just bypassing any register update for BIAS_PULL_PIN_DEFAULT
> and continuing the remaining configuration.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

I've applied the patch as it just brings back the semantics before
commit 03b054e9696c3cbd3d5905ec96da15acd0a2fe8d
"pinctrl: Pass all configs to driver on pin_config_set()"

(Normally you should mention the above in your commit message
with patches like these that are regressions.)
But whatever.

Please look into the related issue pointed out by Stephen as well.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-09-27 16:41    [W:0.083 / U:6.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site