[lkml]   [2013]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 09/27] mmc: mvsdio: Remove redundant suspend and resume callbacks
On 26 September 2013 17:40, Nicolas Pitre <> wrote:
> On Thu, 26 Sep 2013, Ulf Hansson wrote:
>> Suspend and resume of cards are handled by the protocol layer and
>> consequently the mmc_suspend|resume_host APIs are marked as deprecated.
> Having the protocol layer take care of card suspend is perfectly sound.
> However, what about host controllers? Shouldn't they suspend themselves
> as well? There is certainly potential for power saving by gating clocks
> to the host IP block or the like.

Hi Nicolas,

You are right, host drivers shall be responsible to handle power
saving operations, like clocks, power domains, pinctrls, etc. In many
cases I think using only runtime PM should satisfy a host driver's
need to perform the proper power saving.

For mvsdio, there were no host power save operations done in the
suspend/resume callbacks, which is why I removed the callbacks

Kind regards
Ulf Hansson

> Nicolas

 \ /
  Last update: 2013-09-27 11:21    [W:0.109 / U:3.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site