lkml.org 
[lkml]   [2013]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode
On 09/26/2013 11:50 PM, Tejun Heo wrote:
> On Thu, Sep 26, 2013 at 11:37:34PM +0800, Zhang Yanfei wrote:
>>>> + WARN_ONCE(1, "memblock: Failed to allocate memory in bottom up "
>>>> + "direction. Now try top down direction.\n");
>>>> + }
>>>
>>> You and I would know what was going on and what the consequence of the
>>> failure may be but the above warning message is kinda useless to a
>>> user / admin, right? It doesn't really say anything meaningful.
>>>
>>
>> Hmmmm.. May be something like this:
>>
>> WARN_ONCE(1, "Failed to allocated memory above the kernel in bottom-up,"
>> "so try to allocate memory below the kernel.");
>
> How about something like "memblock: bottom-up allocation failed,
> memory hotunplug may be affected\n".
>

Ok, I understand what you want. Explicitly telling the user the functionality
may be invalid due to some failure. Yeah, this is really meaningful, i will
take yours, thanks.

--
Thanks.
Zhang Yanfei


\
 
 \ /
  Last update: 2013-09-26 18:01    [W:0.067 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site