lkml.org 
[lkml]   [2013]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] NFS: Don't use debug-printk-only local variables
Date
Olof Johansson <olof@lixom.net> wrote:

> - struct nfs_inode *nfsi = NFS_I(page->mapping->host);
> struct fscache_cookie *cookie = nfs_i_fscache(page->mapping->host);
>
> BUG_ON(!cookie);
> dfprintk(FSCACHE, "NFS: fscache releasepage (0x%p/0x%p/0x%p)\n",
> - cookie, page, nfsi);
> + cookie, page, NFS_I(page->mapping->host));

This is really the wrong fix. The null dfprintk() should use no_printk().

David


\
 
 \ /
  Last update: 2013-09-26 15:01    [W:0.215 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site