lkml.org 
[lkml]   [2013]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: dgrp: Convert to use device_create_with_groups
On Wed, Sep 25, 2013 at 04:02:44PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Aug 31, 2013 at 03:56:06PM -0700, Guenter Roeck wrote:
> > Use device_create_with_groups to create sysfs attributes together with device.
> > Also create class attribute together with class registration.
> > This simplifies the code and ensures that attribute files exist when udev
> > events are generated.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > I suspect that the 'register_with_sysfs' attribute exists to work around
> > the problem solved with this patch. It doesn't make much sense otherwise.
> > Can it be removed ?
>
> All of these sysfs files can be removed, they shouldn't be there, as it
> looks like they are used for odd configuration things.
>
> And a single tty driver shouldn't be a "class" at all.
>
> sorry,
>
No need to be sorry - not my driver, nor am I using it ;).
I am perfectly fine with you dropping this patch.

Guenter


\
 
 \ /
  Last update: 2013-09-26 01:21    [W:0.059 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site