Messages in this thread | | | Date | Wed, 25 Sep 2013 23:49:40 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 07/21] cpuidle: rearrange __cpuidle_register_device() to keep minimal exit points |
| |
On 09/22/2013 03:20 AM, Viresh Kumar wrote: > This patch rearranges __cpuidle_register_device() a bit in order to reduce the > number of exit points of this function. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpuidle/cpuidle.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c > index 211e504..8c91bad 100644 > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -383,13 +383,12 @@ static int __cpuidle_register_device(struct cpuidle_device *dev) > list_add(&dev->device_list, &cpuidle_detected_devices); > > ret = cpuidle_coupled_register_device(dev); > - if (ret) { > + if (ret) > __cpuidle_unregister_device(dev); > - return ret; > - } > + else > + dev->registered = 1; > > - dev->registered = 1; > - return 0; > + return ret; > }
There is no accounting for taste :)
I agree the patch concentrates more the return statement into a single place which conforms better to the kernel coding style.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |