Messages in this thread | | | Date | Wed, 25 Sep 2013 15:13:23 +0800 | From | Hongbo Zhang <> | Subject | Re: [PATCHv6 02/16] drivers: thermal: introduce device tree parser |
| |
On 09/19/2013 05:35 AM, Eduardo Valentin wrote: > > [...] > + > +/*** sensor API ***/ > +
You are introducing new concept here, the original framework and drivers cannot use this, right? any further plan to update original framework for this new feature?
> +static struct thermal_zone_device * > +thermal_zone_of_add_sensor(struct device_node *zone, > + struct device_node *sensor, void *data, > + int (*get_temp)(void *, long *), > + int (*get_trend)(void *, long *)) > +{ > + struct thermal_zone_device *tzd; > + struct __thermal_zone *tz; > + > + tzd = thermal_zone_get_zone_by_name(zone->name); > + if (IS_ERR(tzd)) > + return ERR_PTR(-EPROBE_DEFER); > + > [...] > + > +/* > + * Here are the thermal trip types. This must > + * match with enum thermal_trip_type at > + * include/linux/thermal.h > + */ > +#define THERMAL_TRIP_ACTIVE 0 > +#define THERMAL_TRIP_PASSIVE 1 > +#define THERMAL_TRIP_HOT 2 > +#define THERMAL_TRIP_CRITICAL 3 > +
These macros seem duplicated with enum thermal_trip_type in thermal.h, do you have further plan to merge them? Or by using string "active", "passive" etc in the dts, then you can reuse the original enum definition.
> +/* On cooling devices upper and lower limits */ > +#define THERMAL_NO_LIMIT (-1UL) > + > +#endif > [...]
| |