Messages in this thread | | | Date | Wed, 25 Sep 2013 12:02:20 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface |
| |
On Fri, Sep 20, 2013 at 07:27:36AM -0500, Tejun Heo wrote: > On Fri, Sep 20, 2013 at 10:24:59AM +0200, Alexander Gordeev wrote: > > * Make pci_enable_msix() return 0/-errno > > My choice would be this one.
I agree; it sounds like you've identified several bugs related to the current confusing interface, so fixing that seems like the first step.
I hope we can avoid adding a plethora of interfaces to address unusual corner cases. But if we do the above and it turns out not to be enough, we can always extend it later.
Bjorn
| |