lkml.org 
[lkml]   [2013]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ti-connectivity: add wl1251 firmware and license
From
Date
On Wed, 2013-09-25 at 14:04 +0300, Luca Coelho wrote:
> Hi dude,
>
> Great, this is cool! Finally! :)
>
> A few comments...
>
>
> On Tue, 2013-09-24 at 09:44 -0500, Felipe Balbi wrote:
> > It's way overdue that we send these firmware
> > blobs upstream. Thanks for everybody involved
> > in getting this sorted out.
> >
> > Cc: Luciano Coelho <luca@coelho.fi>
> > Cc: Pavel Machek <pavel@denx.de>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
>
> The commit message could be a bit more descriptive rather than
> narrative?
>
>
> > ti-connectivity/license-wl1251.txt | 59 +++++++++++++++++++++++++++++++++++++
>
> The license file should be in the root, together with the other licenses
> and called LICENCE.wl1251 (note the en-GB spelling). Also, this license
> is *very* similar to the one for WiLink6/7/8 (LICENCE.ti-connectivity),
> except for some very minor things and the formatting. Couldn't the same
> one be used, for the sake of simplicity and consistency?
>
>
> > ti-connectivity/wl1251-fw.bin | Bin 0 -> 194180 bytes
> > ti-connectivity/wl1251-nvs.bin | Bin 0 -> 752 bytes
> > 3 files changed, 59 insertions(+)
> > create mode 100644 ti-connectivity/license-wl1251.txt
> > create mode 100644 ti-connectivity/wl1251-fw.bin
> > create mode 100644 ti-connectivity/wl1251-nvs.bin
>
> When sending big binary blobs, it's generally better to send pull
> requests instead of patches. If you add the -p option when calling git
> pull-request, the text will include all the readable parts but will omit
> the binary stuff.
>
> Thank you very much for following up on this!

Ah, and I forgot to say that you should update the WHENCE file
accordingly too. Check the wl12xx and wl18xx drivers for examples.

--
Luca.



\
 
 \ /
  Last update: 2013-09-25 13:41    [W:0.170 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site