lkml.org 
[lkml]   [2013]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 071/117] HID: pantherlord: validate output report details
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kees Cook <keescook@chromium.org>

    commit 412f30105ec6735224535791eed5cdc02888ecb4 upstream.

    A HID device could send a malicious output report that would cause the
    pantherlord HID driver to write beyond the output report allocation
    during initialization, causing a heap overflow:

    [ 310.939483] usb 1-1: New USB device found, idVendor=0e8f, idProduct=0003
    ...
    [ 315.980774] BUG kmalloc-192 (Tainted: G W ): Redzone overwritten

    CVE-2013-2892

    Signed-off-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/hid-pl.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    --- a/drivers/hid/hid-pl.c
    +++ b/drivers/hid/hid-pl.c
    @@ -132,8 +132,14 @@ static int plff_init(struct hid_device *
    strong = &report->field[0]->value[2];
    weak = &report->field[0]->value[3];
    debug("detected single-field device");
    - } else if (report->maxfield >= 4 && report->field[0]->maxusage == 1 &&
    - report->field[0]->usage[0].hid == (HID_UP_LED | 0x43)) {
    + } else if (report->field[0]->maxusage == 1 &&
    + report->field[0]->usage[0].hid ==
    + (HID_UP_LED | 0x43) &&
    + report->maxfield >= 4 &&
    + report->field[0]->report_count >= 1 &&
    + report->field[1]->report_count >= 1 &&
    + report->field[2]->report_count >= 1 &&
    + report->field[3]->report_count >= 1) {
    report->field[0]->value[0] = 0x00;
    report->field[1]->value[0] = 0x00;
    strong = &report->field[2]->value[0];



    \
     
     \ /
      Last update: 2013-09-25 03:01    [W:4.180 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site