lkml.org 
[lkml]   [2013]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/6] rwsem: check the lock before cpmxchg in down_write_trylock
From
Date
On Tue, 2013-09-24 at 16:22 -0700, Jason Low wrote:
> Should we do something similar with __down_read_trylock, such as
> the following?
>
>
> Signed-off-by: Jason Low <jason.low2@hp.com>
> ---
> include/asm-generic/rwsem.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-generic/rwsem.h b/include/asm-generic/rwsem.h
> index bb1e2cd..47990dc 100644
> --- a/include/asm-generic/rwsem.h
> +++ b/include/asm-generic/rwsem.h
> @@ -42,6 +42,9 @@ static inline int __down_read_trylock(struct
> rw_semaphore *sem)
> long tmp;
>
> while ((tmp = sem->count) >= 0) {
> + if (sem->count != tmp)
> + continue;
> +

Considering that tmp has just been assigned the value of sem->count, the
added if check failure is unlikely and probably not needed. We should
proceed to cmpxchg below.

> if (tmp == cmpxchg(&sem->count, tmp,
> tmp + RWSEM_ACTIVE_READ_BIAS)) {
> return 1;

Tim



\
 
 \ /
  Last update: 2013-09-25 01:41    [W:0.039 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site