lkml.org 
[lkml]   [2013]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] gpio/omap: auto-setup a GPIO when used as an IRQ
* Javier Martinez Canillas <javier.martinez@collabora.co.uk> [130923 22:49]:
> On 09/23/2013 10:15 PM, Linus Walleij wrote:
> > <javier.martinez@collabora.co.uk> wrote:
> > - When a second caller calls omap_gpio_request() it should
> > be OK as well, but only if the flags corresponds to the
> > previously enabled input mode. Else it should be
> > disallowed.
> >
> > - The same should happen for _set_gpio_direction() if a pin
> > previously set up for IRQ gets a request to be used as
> > output.
> >
> > If this cannot be tracked in the driver, it is certainly a candidate
> > for something that gpiolib should be doing. And then I'm open to
> > solutions to how we can do that.
> >
>
> Ok, this can be tracked in the driver, will add it when posting v2 soon.
>
> > If this needs to be applied pronto to fix the regression I'm
> > happy with that too, if we add a big boilerplate stating the above
> > problem and that it needs to be *fixed* at some point.

In the mainline kernel, the regression is happening at least for
smsc911x using boards, so that's omap3-igep.dtsi and omap3-tobi.dts
currently. Also MMC card detection for omap4 is failing. Then
of course there are tons of boards where we don't have the .dts
files in the mainline kernel yet.

So maybe let's do a minimal fix for the -rc cycle first?

Then the extra checks can be queued for the next merge window
if it gets too intrusive.

> > But in either case I want this to be tested on OMAP1 before
> > I apply it, as in a Tested-by tag.
> >
>
> Agreed. Even though this is a fix for a long standing issue I prefer it to be
> tested extensively than applying the patch in a rush just to learn that causes
> regressions and have to be reverted as it happens last time.
>
> So as you said let's wait until we have a few Tested-by tags by people using
> different OMAP platforms specially OMAP1.

Yup.

Regards,

Tony


\
 
 \ /
  Last update: 2013-09-24 17:41    [W:0.129 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site