lkml.org 
[lkml]   [2013]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] perf bench: Change the procps visible command-name of invididual benchmark tests
On 9/24/13 4:39 AM, Ingo Molnar wrote:
> +/*
> + * Run a specific benchmark but first rename the running task's ->comm[]
> + * to something meaningful:
> + */
> +static int run_bench(const char *subsys_name, const char *bench_name, bench_fn_t fn, int argc, const char **argv, const char *prefix)

As I recall you are a fan of longer line lengths, but this seems
excessive. ;-)

---8<---

> +}
> +
> +static void all_suites(struct bench_subsys *subsys) /* FROM HERE */

Might as well drop the /* FROM HERE */.

---8<---

> @@ -244,8 +269,7 @@ int cmd_bench(int argc, const char **arg
> subsystems[i].name,
> subsystems[i].suites[j].name);
> fflush(stdout);
> - status = subsystems[i].suites[j].fn(argc - 1,
> - argv + 1, prefix);
> + status = run_bench(subsystems[i].name, subsystems[i].suites[j].name, subsystems[i].suites[j].fn, argc - 1, argv + 1, prefix);

another one that is rather long.

David




\
 
 \ /
  Last update: 2013-09-24 15:01    [W:0.035 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site