Messages in this thread Patch in this message | | | Date | Tue, 24 Sep 2013 06:39:52 -0600 | From | David Ahern <> | Subject | Re: [PATCH] perf bench: Change the procps visible command-name of invididual benchmark tests |
| |
On 9/24/13 4:39 AM, Ingo Molnar wrote: > +/* > + * Run a specific benchmark but first rename the running task's ->comm[] > + * to something meaningful: > + */ > +static int run_bench(const char *subsys_name, const char *bench_name, bench_fn_t fn, int argc, const char **argv, const char *prefix)
As I recall you are a fan of longer line lengths, but this seems excessive. ;-)
---8<---
> +} > + > +static void all_suites(struct bench_subsys *subsys) /* FROM HERE */
Might as well drop the /* FROM HERE */.
---8<---
> @@ -244,8 +269,7 @@ int cmd_bench(int argc, const char **arg > subsystems[i].name, > subsystems[i].suites[j].name); > fflush(stdout); > - status = subsystems[i].suites[j].fn(argc - 1, > - argv + 1, prefix); > + status = run_bench(subsystems[i].name, subsystems[i].suites[j].name, subsystems[i].suites[j].fn, argc - 1, argv + 1, prefix);
another one that is rather long.
David
| |