lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thermal: st: Add support for STiH41x thermal sensors
On Thursday 19 September 2013 01:32 AM, Eduardo Valentin wrote:
> On 18-09-2013 05:38, Ajit Pal Singh wrote:
>> Adds support for thermal sensors on STiH41x series SOCs.
>> Single trip point 'THERMAL_TRIP_CRITICAL' is supported.
>> STIH416 MPE sensor supports interrupt reporting when a preset
>> threshold temperature is crossed.
>> For rest of the thermal sensors a polling delay of 10000ms is
>> set.
>>
>> CC: Stephen Gallimore <stephen.gallimore@st.com>
>> CC: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>> Signed-off-by: Ajit Pal Singh <ajitpal.singh@st.com>
[snip]
>> +static irqreturn_t st_thermal_thresh_int(int irq, void *data)
>> +{
>> + struct st_thermal_sensor *sensor = data;
>> + struct device *dev = sensor_to_dev(sensor);
>> +
>> + dev_dbg(dev, "%s,called\n", __func__);
>> + thermal_zone_device_update(sensor->th_dev);
>
> Are you sure you want to do this here? The above call might sleep.

Have used devm_request_threaded_irq() to register the above threaded irq
handler. Calling sleep-able calls from the threaded interrupt handler
should be OK ?
>
>> + return IRQ_HANDLED;
>> +}
[snip]
>> +static int st_thermal_notify(struct thermal_zone_device *th,
>> + int trip, enum thermal_trip_type type)
>> +{
>> + struct st_thermal_sensor *sensor = thzone_to_sensor(th);
>> + struct device *dev = sensor_to_dev(sensor);
>> +
>> + switch (type) {
>> + case THERMAL_TRIP_CRITICAL:
>> + /* TODO: Send event to user space */
>
> It depends on what you mean by that. The core code will attempt to call
> the shutdown command, in user space.

Will remove the comment in the next version of the patch.
>
>> + dev_err(dev, "Critical temp reached:Going for shutdown\n");
>> + break;
>> + default:
>> + return -EINVAL;
>> + }
>> + return 0;
>> +}
>> +
[snip]
>> +module_platform_driver(st_thermal_driver);
>> +MODULE_AUTHOR("STMicroelectronics (R&D) Limited");
>> +MODULE_DESCRIPTION("STMicroelectronics STIH41x SOC thermal sensor driver");
>> +MODULE_LICENSE("GPL");
>
> GPL v2?

OK.Will make it GPLv2
>

Thanks
Ajit Pal Singh



\
 
 \ /
  Last update: 2013-09-23 10:41    [W:0.041 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site