[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/5] mfd: arizona: Add device tree bindings for MICBIAS generators
On 09/23/2013 12:30 PM, Charles Keepax wrote:
> Add device tree bindings for the pdata needed to configure the MICBIAS
> generators.

> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt

> + - wlf,micbias1 : Configuration for the micbias regulator, should include 5
> + cells.
> + The first cell is the output voltage in millivolts
> + The second cell a non-zero value indicates an external capacitor is fitted

I think you need some kind of delimiter (e.g. a colon) after "cell"
there, to separate the line's label and description.

> + The four cell a non-zero value indicates that the micbias should be


There are lots of cells here with a single-bit flag in them. Can the
flags be combined into a single cell to reduce the DT size? cpp-based
named constants should keep the *.dts file readable.

 \ /
  Last update: 2013-09-24 01:21    [W:0.146 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site