Messages in this thread | | | Date | Mon, 23 Sep 2013 16:03:18 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information |
| |
On 09/23/2013 01:32 PM, Felipe Balbi wrote: > Hi, > > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: >> From: "Ivan T. Ivanov" <iivanov@mm-sol.com> >> >> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) >> and HS, SS PHY's control and configuration registers. >> >> It could operate in device mode (SS, HS, FS) and host mode (SS, >> HS, FS, LS). >> >> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > > and here's a new version from same patch
The binding looks pretty simple, so I don't think it's too contentious.
>> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt >> b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>> +MSM DWC3 controller wrapper
>> +Optional properties : +- gdsc-supply : phandle to the globally >> distributed switch controller + regulator node to the USB >> controller.
If that's a regulator node, why not use xxx-supply properties to interface with it?
Aside from that, the binding, Acked-by: Stephen Warren <swarren@nvidia.com>
| |