lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kmod: Check for NULL at call_usermodehelper_exec().
On Tue, 24 Sep 2013 06:12:34 +0900 Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:

> Andrew, would you pick up this patch?
>
> Regards.
> ----------
> >From d6ff218545060c5f8b75b15d5b34bffcf625508f Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Mon, 16 Sep 2013 02:19:10 +0900
> Subject: [PATCH] kmod: Check for NULL at call_usermodehelper_exec().
>
> If /proc/sys/kernel/core_pattern contains only "|", NULL pointer dereference
> happens upon core dump because argv_split("") returns argv[0] == NULL.
>
> This bug was once fixed by commit 264b83c0 "usermodehelper: check
> subprocess_info->path != NULL" but was by error reintroduced by commit
> 7f57cfa4 "usermodehelper: kill the sub_info->path[0] check".
>
> This bug seems to exist since 2.6.19 (the version which core dump to pipe was
> added). Depending on kernel version and config, some side effect might happen
> immediately after this oops (e.g. kernel panic with 2.6.32-358.18.1.el6).
>
> ...
>
> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -571,6 +571,10 @@ int call_usermodehelper_exec(struct subprocess_info *sub_info, int wait)
> DECLARE_COMPLETION_ONSTACK(done);
> int retval = 0;
>
> + if (!sub_info->path) {
> + call_usermodehelper_freeinfo(sub_info);
> + return -ENOENT;
> + }
> helper_lock();
> if (!khelper_wq || usermodehelper_disabled) {
> retval = -EBUSY;

The error is that the user put a bare "|" into
/proc/sys/kernel/core_pattern. Is ENOENT ("No such file or directory")
the most appropriate error code here? I think EINVAL ("Invalid
argument")?



\
 
 \ /
  Last update: 2013-09-24 00:01    [W:0.072 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site