lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/5] memblock: Improve memblock to support allocation from lower address.
Hello,

On Tue, Sep 24, 2013 at 02:07:13AM +0800, Zhang Yanfei wrote:
> Yes, I am following your advice in principle but kind of confused by
> something you said above. Where should the set_memblock_alloc_above_kernel
> be used? IMO, the function is like:
>
> find_in_range_node()
> {
> if (ok) {
> /* bottom-up */
> ret = __memblock_find_in_range(max(start, _end_of_kernel), end...);
> if (!ret)
> return ret;
> }
>
> /* top-down retry */
> return __memblock_find_in_range_rev(start, end...)
> }
>
> For bottom-up allocation, we always start from max(start, _end_of_kernel).

Oh, I was talking about naming of the memblock_set_bottom_up()
function. We aren't really doing pure bottom up allocations, so I
think it probably would be clearer if the name clearly denotes that
we're doing above-kernel allocation.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-09-23 22:41    [W:0.075 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site