[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [tpmdd-devel] [PATCH 09/13] tpm: Pull everything related to sysfs into tpm-sysfs.c
On 09/23/2013 02:14 PM, Jason Gunthorpe wrote:
> CLASS-sysfs.c is a common idiom for linux subsystems.
> This pulls all the sysfs attribute functions and related code
> into tpm-sysfs.c. To support this change some constants are moved
> from tpm.c to tpm.h and __tpm_pcr_read is made non-static and is
> called tpm_pcr_read_dev.
> Signed-off-by: Jason Gunthorpe <>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 12a4ab2..7892557 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> -static DEVICE_ATTR(durations, S_IRUGO, tpm_show_durations, NULL);
> -static DEVICE_ATTR(timeouts, S_IRUGO, tpm_show_timeouts, NULL);
> -static DEVICE_ATTR(locality, S_IRUGO | S_IWUSR, tpm_show_locality,
> - tpm_store_locality);

This patch drops the "locality" sysfs attribute from xen-tpmfront. Since
that attribute is currently only implemented for the xen TPM driver, it
is best to leave it there for now (and its show/store functions could
also be made static, an oversight I just noticed now). If this attribute
is later made available on other TPM drivers, it may need to contain
device-specific logic, but such an implementation is well outside the
scope of this series.

Daniel De Graaf
National Security Agency

 \ /
  Last update: 2013-09-23 21:21    [W:0.237 / U:16.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site