lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/13] tpm: xen-tpmfront: Fix default durations
On Mon, Sep 23, 2013 at 12:14:33PM -0600, Jason Gunthorpe wrote:
> All the default durations were being set to 10 minutes which is
> way too long for the timeouts. Normal values for the longest
> duration are around 5 mins, and short duration ar around .5s.
>
> Further, these are just the default, tpm_get_timeouts will set
> them to values from the TPM (or throw an error).
>
> Just remove them.

Sounds sensible.

Daniel?

>
> Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> ---
> drivers/char/tpm/xen-tpmfront.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 7a7929b..6f2fe2b 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -210,8 +210,6 @@ static struct attribute_group vtpm_attr_grp = {
> .attrs = vtpm_attrs,
> };
>
> -#define TPM_LONG_TIMEOUT (10 * 60 * HZ)
> -
> static const struct tpm_vendor_specific tpm_vtpm = {
> .status = vtpm_status,
> .recv = vtpm_recv,
> @@ -224,11 +222,6 @@ static const struct tpm_vendor_specific tpm_vtpm = {
> .miscdev = {
> .fops = &vtpm_ops,
> },
> - .duration = {
> - TPM_LONG_TIMEOUT,
> - TPM_LONG_TIMEOUT,
> - TPM_LONG_TIMEOUT,
> - },
> };
>
> static irqreturn_t tpmif_interrupt(int dummy, void *dev_id)
> --
> 1.8.1.2
>


\
 
 \ /
  Last update: 2013-09-23 21:21    [W:0.232 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site