lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/26] ARM: dove: remove custom .init_time hook
On 09/23/2013 03:32 PM, Jason Cooper wrote:
> On Mon, Sep 23, 2013 at 11:10:36AM +0200, Andrew Lunn wrote:
>> On Sun, Sep 22, 2013 at 02:20:28PM +0200, Sebastian Hesselbarth wrote:
>>> On 09/21/2013 02:22 PM, Andrew Lunn wrote:
>>>> On Wed, Sep 18, 2013 at 07:53:44PM +0200, Sebastian Hesselbarth wrote:
>>>>> With arch/arm calling of_clk_init(NULL) from time_init(), we can now
>>>>> remove custom .init_time hooks. While at it, also remove some obsolete
>>>>> includes.
>>>>>
>>>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>>>> ---
>>>>> Cc: Olof Johansson <olof@lixom.net>
>>>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>>>> Cc: Jason Cooper <jason@lakedaemon.net>
>>>>> Cc: Andrew Lunn <andrew@lunn.ch>
>>>>> Cc: Russell King <linux@arm.linux.org.uk>
>>>>> Cc: linux-arm-kernel@lists.infradead.org
>>>>> Cc: linux-kernel@vger.kernel.org
>>>>> ---
>>>>> arch/arm/mach-dove/board-dt.c | 11 -----------
>>>>> 1 file changed, 11 deletions(-)
>>> [...]
>>>> Boot tested on cubox.
>>>>
>>>> Tested-by: Andrew Lunn <andrew@lunn.ch>
>>>
>>> Thanks Andrew!
>>>
>>> Aren't you giving any Acks for dove/kirkwood anymore?
>>
>> Hi Sebastian
>>
>> In my opinion, a Tested-by: has more weight than an Acked-by. I could
>> of given you an Acked-by in about 60 seconds, given the simplicity of
>> the patch. It took a lot more effort to get your tree, build it, fix
>> my binutils, since it was the first 3.12 tree i had tried and my
>> binutils was too old, and boot it.
>
> I would even go so far as to say that a Tested-by: from a maintainer
> carries an implied Ack. ;-)
>
> And, just for the record,
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>

True, True, True. Lesson learned ;)

Thanks for both testing and ack'ing.

Sebastian



\
 
 \ /
  Last update: 2013-09-23 20:01    [W:0.271 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site