Messages in this thread | | | Date | Mon, 23 Sep 2013 13:11:08 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v3 5/5] mem-hotplug: Introduce movablenode boot option to control memblock allocation direction. |
| |
Hello,
On Tue, Sep 24, 2013 at 12:58:03AM +0800, Zhang Yanfei wrote: > you mean we define memblock_set_bottom_up and memblock_bottom_up like below: > > #ifdef CONFIG_MOVABLE_NODE > void memblock_set_bottom_up(bool enable) > { > /* do something */ > } > > bool memblock_bottom_up() > { > return direction == bottom_up; > } > #else > void memblock_set_bottom_up(bool enable) > { > /* empty */ > } > > bool memblock_bottom_up() > { > return false; > } > #endif > > right?
Yeah, the compiler would be able to drop bottom_up code if !MOVABLE_NODE as long as the implementation functions are static.
Thanks.
-- tejun
| |