lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] mem-hotplug: Introduce movablenode boot option to control memblock allocation direction.
Hello tejun,

On 09/23/2013 11:57 PM, Tejun Heo wrote:
> Hello,
>
> On Fri, Sep 13, 2013 at 05:30:55PM +0800, Tang Chen wrote:
>> +#ifdef CONFIG_MOVABLE_NODE
>> + if (movablenode_enable_srat) {
>> + /*
>> + * When ACPI SRAT is parsed, which is done in initmem_init(),
>> + * set memblock back to the default behavior.
>> + */
>> + memblock_set_current_direction(MEMBLOCK_DIRECTION_DEFAULT);
>> + }
>> +#endif /* CONFIG_MOVABLE_NODE */
>
> It's kinda weird to have ifdef around the above when all the actual
> code would be compiled and linked regardless of the above ifdef.
> Wouldn't it make more sense to conditionalize
> memblock_direction_bottom_up() so that it's constant false to allow
> the compiler to drop unnecessary code?

you mean we define memblock_set_bottom_up and memblock_bottom_up like below:

#ifdef CONFIG_MOVABLE_NODE
void memblock_set_bottom_up(bool enable)
{
/* do something */
}

bool memblock_bottom_up()
{
return direction == bottom_up;
}
#else
void memblock_set_bottom_up(bool enable)
{
/* empty */
}

bool memblock_bottom_up()
{
return false;
}
#endif

right?

thanks.

>
> Thanks.
>


--
Thanks.
Zhang Yanfei


\
 
 \ /
  Last update: 2013-09-23 19:41    [W:0.076 / U:2.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site