Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH v2] block: register_blkdev doesn't check name against NULL | Date | Mon, 23 Sep 2013 10:56:27 -0400 |
| |
Vaughan Cao <vaughan.cao@oracle.com> writes:
> register_blkdev(0, NULL) can result kernel Oops by copying from NULL > in strlcpy(). Fix it by checking NULL pointer at the beginning and > WARN when encountered in unregister_blkdev.
Uhh, so yeah, this is an exported function, so I could see maybe wanting to do the argument checking. But honestly, if your driver can't even get this right, is there any hope of it actually working?
This seems like a pointless patch to me, but ultimately it's up to Jens.
Cheers, Jeff
p.s. the kerneldoc tells you what to put there: * @name: the name of the new block device as a zero terminated string
| |