lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] usb: dwc3: Remove additional delay of 100ms when resuming
Date
On Monday, September 23, 2013 12:38 PM, Vivek Gautam wrote:
>
> This delay got introduced in:
> "7415f17 usb: dwc3: core: add power management support"
> which reflected similar code in dwc3_core_soft_reset() function.
> However, originally the delay of 100ms in dwc3_core_soft_reset() was
> meant to assist USB2PHY and USB3PHY reset, not for usb_phy_init()
> sequence.
>
> We should get rid of this delay, since things will still work
> fine without this.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

OK, I see.
There is no reason to add msleep(100) to dwc3_resume();
thus, this msleep(100) can be removed.

Best regards,
Jingoo Han

> ---
>
> Hi Felipe,
>
> I remember this change for phy_init including msleep(100) was
> suggested by me, after testing the patch-series for PM support
> to dwc3.
> Sorry for that !!
>
> drivers/usb/dwc3/core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 474162e..e88ffae 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -691,7 +691,6 @@ static int dwc3_resume(struct device *dev)
>
> usb_phy_init(dwc->usb3_phy);
> usb_phy_init(dwc->usb2_phy);
> - msleep(100);
>
> spin_lock_irqsave(&dwc->lock, flags);
>
> --
> 1.7.6.5




\
 
 \ /
  Last update: 2013-09-23 08:41    [W:0.041 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site