lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/5] xen/PMU: Sysfs interface for setting Xen PMU mode
On 09/23/2013 09:17 AM, Konrad Rzeszutek Wilk wrote:
> On Tue, Sep 10, 2013 at 11:31:47AM -0400, Boris Ostrovsky wrote:
>> +
>> +/* Parameter structure for HYPERVISOR_xenpmu_op call */
>> +struct xenpmu_params {
>> + union {
>> + struct version {
>> + uint8_t maj;
>> + uint8_t min;
>> + } version;
>> + uint64_t pad;
>> + };
>> + uint64_t control;
>> +};
>> +
>> +/* VPMU modes */
>> +#define VPMU_MODE_MASK 0xff
>> +#define VPMU_OFF 0
>> +/* guests can profile themselves, (dom0 profiles itself and Xen) */
>> +#define VPMU_ON (1<<0)
>> +/*
>> + * Only dom0 has access to VPMU and it profiles everyone: itself,
>> + * the hypervisor and the guests.
>> + */
>> +#define VPMU_PRIV (1<<1)
>> +
>> +/* VPMU flags */
>> +#define VPMU_FLAGS_MASK ((uint32_t)(~VPMU_MODE_MASK))
>> +#define VPMU_INTEL_BTS (1<<8) /* Ignored on AMD */
>> +
>> +#endif /* __XEN_PUBLIC_XENPMU_H__ */
> Looks OK to me if there are no changes to the hypervisor ABI.


v2 patches for hypervisor have different layout for shared structures
and parameters so this will have to change as well. I don't believe
there are any logic changes to this series due to this v2, except for
the first patch (getting Xen symbols into dom0).

-boris


\
 
 \ /
  Last update: 2013-09-23 16:21    [W:0.150 / U:39.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site