lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: checkpatch guide for newbies
On Mon, Sep 23, 2013 at 02:46:38PM +0200, Peter Senna Tschudin wrote:
> > It's preferred if the operator goes at the end of the first line instead of at
> > the start of the second line:
> > Bad:
> > - PowerData = (1 << 31) | (0 << 30) | (24 << 24)
> > - | BitReverse(w89rf242_txvga_data[i][0], 24);
> > Good:
> > + PowerData = (1 << 31) | (0 << 30) | (24 << 24) |
> > + BitReverse(w89rf242_txvga_data[i][0], 24);
> What is the rule for where to start the second line here?
>

The if statement alignment has become a rule and people will make you
redo it if it's not aligned. I haven't seen anyone have to redo a
patch because of alignment on these:

My favorite format is aligned:
foo = xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx -
yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy;

Also popular:
foo = xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx -
yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy;

Right aligned looks like nonsense:
foo = xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx -
yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy;

Here is a more complex aligned statement:
foo = bar * (xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx -
yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy);

regards,
dan carpenter


\
 
 \ /
  Last update: 2013-09-23 16:01    [W:0.082 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site