lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] gpio / ACPI: register to ACPI events automatically
On Fri, Sep 20, 2013 at 09:08:57PM +0200, Linus Walleij wrote:
> On Fri, Sep 13, 2013 at 5:14 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
>
> > Instead of asking each driver to register to the ACPI events we can just
> > call acpi_gpiochip_register_interrupts() for each chip that has ACPI
> > handle. It checks chip->to_irq and if it is set to NULL (a GPIO driver that
> > doesn't do interrupts) the function does nothing.
> >
> > Also make the event interface to be private to gpiolib-acpi and remove call
> > to the API from the one existing user (pinctrl-baytrail.c).
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> The concept looks sane...
>
> > +void acpi_gpiochip_add(struct gpio_chip *chip)
> > +{
> > + acpi_gpiochip_request_interrupts(chip);
> > +}
> > +EXPORT_SYMBOL_GPL(acpi_gpiochip_add);
> > +
> > +void acpi_gpiochip_remove(struct gpio_chip *chip)
> > +{
> > + acpi_gpiochip_free_interrupts(chip);
> > +}
> > +EXPORT_SYMBOL_GPL(acpi_gpiochip_remove);
>
> If you're only going to call this from within gpiolib, why are
> you EXPORTing the APIs?
>
> I think we should maybe create drivers/gpio/gpiolib.h
> for such subsystem-local headers.

Good point. Will do that in the next version.

> > @@ -1221,6 +1222,7 @@ int gpiochip_add(struct gpio_chip *chip)
> > #endif
> >
> > of_gpiochip_add(chip);
> > + acpi_gpiochip_add(chip);
> >
> > if (status)
> > goto fail;
> > @@ -1262,6 +1264,7 @@ int gpiochip_remove(struct gpio_chip *chip)
> >
> > gpiochip_remove_pin_ranges(chip);
> > of_gpiochip_remove(chip);
> > + acpi_gpiochip_remove(chip);
>
> What happens on a platform that is not using CONFIG_GPIO_ACPI
> when they try to compile this?
>
> You forgot to add static inline stubs for the non-ACPI case.

This patch adds them to <linux/acpi_gpio.h> which is included from
gpiolib.c.


\
 
 \ /
  Last update: 2013-09-23 13:01    [W:0.098 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site