lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/21] cpuidle: make __cpuidle_driver_init() return void
On 09/22/2013 09:20 AM, Viresh Kumar wrote:
> __cpuidle_driver_init() doesn't return anything except zero and so doesn't
> really need a return type other than void.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpuidle/driver.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
> index 25455e8..8df66c8 100644
> --- a/drivers/cpuidle/driver.c
> +++ b/drivers/cpuidle/driver.c
> @@ -152,7 +152,7 @@ static void cpuidle_setup_broadcast_timer(void *arg)
> *
> * Returns 0 on success, a negative error code otherwise.
If you want to make it return void, you should also update the above
comment.
> */
> -static int __cpuidle_driver_init(struct cpuidle_driver *drv)
> +static void __cpuidle_driver_init(struct cpuidle_driver *drv)
> {
> int i;
>
> @@ -179,8 +179,6 @@ static int __cpuidle_driver_init(struct cpuidle_driver *drv)
> drv->bctimer = 1;
> break;
> }
> -
> - return 0;
> }
>
> /**
> @@ -206,9 +204,7 @@ static int __cpuidle_register_driver(struct cpuidle_driver *drv)
> if (cpuidle_disabled())
> return -ENODEV;
>
> - ret = __cpuidle_driver_init(drv);
> - if (ret)
> - return ret;
> + __cpuidle_driver_init(drv);
>
> ret = __cpuidle_set_driver(drv);
> if (ret)





\
 
 \ /
  Last update: 2013-09-23 12:21    [W:0.257 / U:9.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site