lkml.org 
[lkml]   [2013]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] perf tools: Use per-file CFLAGS in Makefile
Date
Hi Jiri,

On Sat, 21 Sep 2013 14:47:14 +0200, Jiri Olsa wrote:
> On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> Some files need additional compiler flags to be built successfully.
>> Cleanup Makefile by using optional per-file CFLAGS which look like
>> CFLAGS_dir_filename.o
>
> I like it, but I'm getting following error:
>
> $ make
> ...
> AR libperf.a
> ar: util/rbtree.o: No such file or directory
> make: *** [libperf.a] Error 1
> $
>
> probably because rbtree object is based in kernel lib
>
>
> Also this patch collides with your previous:
> perf tools: Separate out GTK codes to libperf-gtk.so
>
> which I needed to revert first to get this one applied.

Thanks for the feedback. I'll take a look and fix them.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-09-23 11:41    [W:0.084 / U:2.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site