lkml.org 
[lkml]   [2013]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Block IO fixes for 3.12
On Sun, Sep 22 2013, Linus Torvalds wrote:
> On Sun, Sep 22, 2013 at 2:55 PM, Jens Axboe <axboe@kernel.dk> wrote:
> >
> > Mike Christie (1):
> > If the queue is dying then we only call the rq->end_io callout. This leaves bios setup on the request, because the caller assumes when the blk_execute_rq_nowait/blk_execute_rq call has completed that the rq->bios have been cleaned up.
>
> Christ people.
>
> We have rules for commit messages. Those rules have things like
> "one-line commit summary at the top", because without that things like
> summary logs (ie "git shortlog") and "gitk" don't do a good job.
>
> How long have we been doing this? I'm used to seeing some odd commit
> messages outside the kernel repo, but am used to kernel people getting
> the trivial details right.
>
> That's not the only one. Look at commit 577cee1e8db6 for some other
> cruddy commit messages. Just because somebody said "Hello" in email
> doesn't mean that it should remain that way in a commit message.
>
> So out of seven commit messages, two were badly formatted. That's not
> a sign of good quality control.

Not necessarily bad quality control, but yeah, the commit messages
could've been prettier. Those two should have been git ammended, most of
them are directly applied byt git am fwiw.

--
Jens Axboe



\
 
 \ /
  Last update: 2013-09-23 01:41    [W:0.044 / U:30.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site