lkml.org 
[lkml]   [2013]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RESEND] printk: report boot console names during cut-over
    On Fri, Sep 20, 2013 at 08:34:01AM -0700, Kees Cook wrote:
    > This reports the names of boot consoles as they're being disabled to
    > help identify which is which during cut-over. Helps answer the question
    > "which boot console actually got activated?" once the regular console
    > is running, mostly when debugging boot console failures.
    >
    > Signed-off-by: Kees Cook <keescook@chromium.org>
    > ---
    > kernel/printk/printk.c | 16 ++++++++++------
    > 1 file changed, 10 insertions(+), 6 deletions(-)
    >
    > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
    > index b4e8500..0dc54c9 100644
    > --- a/kernel/printk/printk.c
    > +++ b/kernel/printk/printk.c
    > @@ -2361,14 +2361,18 @@ void register_console(struct console *newcon)
    > if (bcon &&
    > ((newcon->flags & (CON_CONSDEV | CON_BOOT)) == CON_CONSDEV) &&
    > !keep_bootcon) {
    > - /* we need to iterate through twice, to make sure we print
    > - * everything out, before we unregister the console(s)
    > + /* We need to iterate through all boot consoles, to make
    > + * sure we print everything out, before we unregister them.
    > */
    > - printk(KERN_INFO "console [%s%d] enabled, bootconsole disabled\n",
    > - newcon->name, newcon->index);
    > - for_each_console(bcon)
    > - if (bcon->flags & CON_BOOT)
    > + for_each_console(bcon) {
    > + if (bcon->flags & CON_BOOT) {
    > + printk(KERN_INFO "console [%s%d] enabled, "
    > + "bootconsole [%s%d] disabled\n",
    > + newcon->name, newcon->index,
    > + bcon->name, bcon->index);
    > unregister_console(bcon);

    Looks useful! But I think the "console %foo disabled" message should move to unregister_console()
    instead. That way it also handles printk_late_init() and all other console unregisters.

    Thanks.


    \
     
     \ /
      Last update: 2013-09-22 02:21    [W:3.185 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site